hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22003) Shared work optimizer may leave semijoin branches in plan that are not used
Date Tue, 23 Jul 2019 00:06:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22003?focusedWorklogId=280712&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-280712
]

ASF GitHub Bot logged work on HIVE-22003:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jul/19 00:05
            Start Date: 23/Jul/19 00:05
    Worklog Time Spent: 10m 
      Work Description: vineetgarg02 commented on pull request #729: HIVE-22003
URL: https://github.com/apache/hive/pull/729#discussion_r306081962
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
 ##########
 @@ -486,6 +510,75 @@ private static boolean sharedWorkOptimization(ParseContext pctx, SharedWorkOptim
     return mergedExecuted;
   }
 
+  private static void replaceSemijoinExpressions(TableScanOperator tsOp, List<ExprNodeDesc>
semijoinExprNodes) {
 
 Review comment:
   This makes sense. Thanks for the explanation. Would you mind adding a comment to `replaceSemijoinExpressions`?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 280712)
    Time Spent: 1h 10m  (was: 1h)

> Shared work optimizer may leave semijoin branches in plan that are not used
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-22003
>                 URL: https://issues.apache.org/jira/browse/HIVE-22003
>             Project: Hive
>          Issue Type: Bug
>          Components: Physical Optimizer
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22003.01.patch, HIVE-22003.01.patch, HIVE-22003.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This may happen only when the TS are the only operators that are shared. Repro attached
in q file.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message