hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23561) FIX Arrow Decimal serialization for native VectorRowBatches
Date Tue, 01 Sep 2020 00:48:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23561?focusedWorklogId=476943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476943
]

ASF GitHub Bot logged work on HIVE-23561:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Sep/20 00:47
            Start Date: 01/Sep/20 00:47
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] commented on pull request #1038:
URL: https://github.com/apache/hive/pull/1038#issuecomment-684124233


   This pull request has been automatically marked as stale because it has not had recent
activity. It will be closed if no further activity occurs.
   Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 476943)
    Remaining Estimate: 0h
            Time Spent: 10m

> FIX Arrow Decimal serialization for native VectorRowBatches
> -----------------------------------------------------------
>
>                 Key: HIVE-23561
>                 URL: https://issues.apache.org/jira/browse/HIVE-23561
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-23561.01.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Arrow Serializer does not properly handle Decimal primitive values when selected array
is used.
> In more detail, decimalValueSetter should be setting the value at *arrowIndex[i]* as
the value at *hiveIndex[j]*, however currently its using the _same_ index!
> https://github.com/apache/hive/blob/eac25e711ea750bc52f41da7ed3c32bfe36d4f67/ql/src/java/org/apache/hadoop/hive/ql/io/arrow/Serializer.java#L926
> This works fine for cases where i == j (selected is not used) but returns wrong decimal
row values when i != j.
> This ticket fixes this inconsistency and adds tests with selected indexes for all supported
types



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message