hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24484) Upgrade Hadoop to 3.3.1
Date Tue, 27 Jul 2021 15:34:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24484?focusedWorklogId=628565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628565
]

ASF GitHub Bot logged work on HIVE-24484:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jul/21 15:33
            Start Date: 27/Jul/21 15:33
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #1742:
URL: https://github.com/apache/hive/pull/1742#discussion_r677540831



##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/WarehouseInstance.java
##########
@@ -394,16 +393,13 @@ WarehouseInstance verifyResults(String[] data) throws IOException {
   }
 
   WarehouseInstance verifyFailure(String[] data) throws IOException {
-    List<String> results = getOutput();
-    logger.info("Expecting {}", StringUtils.join(data, ","));
-    logger.info("Got {}", results);
-    boolean dataMatched = (data.length == results.size());
-    if (dataMatched) {
-      for (int i = 0; i < data.length; i++) {
-        dataMatched &= data[i].toLowerCase().equals(results.get(i).toLowerCase());
-      }
-    }
-    assertFalse(dataMatched);
+    final List<String> expectedResults =
+        Arrays.asList(data).stream().map(r -> r.toLowerCase()).collect(Collectors.toList());
+    final List<String> actualResults = getOutput().stream().map(r -> r.toLowerCase()).collect(Collectors.toList());
+
+    assertTrue("Data " + expectedResults + " should not be present in " + actualResults,
+        Collections.disjoint(expectedResults, actualResults));
+

Review comment:
       old and new code seem to be doing  different things
   old is:
   ```
   e[0] != r[0] || ... || e[n] != r[n]
   ```
   new block is a condition which is checking a set operation between the elements...
   
   why is this change necessary - how this is connected to a hadoop upgrade?
   

##########
File path: ql/src/test/results/clientpositive/llap/check_constraint.q.out
##########
@@ -2415,14 +2415,14 @@ STAGE PLANS:
                 outputColumnNames: _col0, _col1, _col2, _col3, _col4, _col5
                 Statistics: Num rows: 1 Data size: 409 Basic stats: COMPLETE Column stats:
NONE
                 Select Operator
-                  expressions: _col1 (type: string), _col0 (type: int), _col4 (type: string),
_col5 (type: struct<writeid:bigint,bucketid:int,rowid:bigint>), _col2 (type: string),
_col3 (type: int)
+                  expressions: _col0 (type: int), _col4 (type: string), _col3 (type: int),
_col1 (type: string), _col5 (type: struct<writeid:bigint,bucketid:int,rowid:bigint>),
_col2 (type: string)

Review comment:
       the join operand order seem to have changed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 628565)
    Time Spent: 5.55h  (was: 5h 23m)

> Upgrade Hadoop to 3.3.1
> -----------------------
>
>                 Key: HIVE-24484
>                 URL: https://issues.apache.org/jira/browse/HIVE-24484
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5.55h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message