hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-24590) Operation Logging still leaks the log4j Appenders
Date Thu, 01 Jul 2021 07:50:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-24590?focusedWorklogId=617446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617446
]

ASF GitHub Bot logged work on HIVE-24590:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/21 07:49
            Start Date: 01/Jul/21 07:49
    Worklog Time Spent: 10m 
      Work Description: zabetak commented on pull request #2432:
URL: https://github.com/apache/hive/pull/2432#issuecomment-872010471


   Hi @prasanthj , following your last comment on https://github.com/apache/hive/pull/1849
I added Hive property to control the lifespan of appenders in https://github.com/apache/hive/pull/2432/commits/bc683ec2d6959e5aba7d216abcd060a07e854d46.

   
   Ideally the whole programmatic registration of the appender should be replaced by `log4j.properties`
or other more standard mechanism but this is a bit more complicated to do so I would leave
it outside the scope of this PR. 
   
   All the tests are green, so if you can have a final look and merge it that would be great
since apparently more people are hitting this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 617446)
    Time Spent: 2h 40m  (was: 2.5h)

> Operation Logging still leaks the log4j Appenders
> -------------------------------------------------
>
>                 Key: HIVE-24590
>                 URL: https://issues.apache.org/jira/browse/HIVE-24590
>             Project: Hive
>          Issue Type: Bug
>          Components: Logging
>            Reporter: Eugene Chung
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: Screen Shot 2021-01-06 at 18.42.05.png, Screen Shot 2021-01-06 at
18.42.24.png, Screen Shot 2021-01-06 at 18.42.55.png, Screen Shot 2021-01-06 at 21.38.32.png,
Screen Shot 2021-01-06 at 21.47.28.png, Screen Shot 2021-01-08 at 21.01.40.png, add_debug_log_and_trace.patch
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> I'm using Hive 3.1.2 with options below.
>  * hive.server2.logging.operation.enabled=true
>  * hive.server2.logging.operation.level=VERBOSE
>  * hive.async.log.enabled=false
> I already know the ticket, https://issues.apache.org/jira/browse/HIVE-17128 but HS2
still leaks log4j RandomAccessFileManager.
> !Screen Shot 2021-01-06 at 18.42.05.png|width=756,height=197!
> I checked the operation log file which is not closed/deleted properly.
> !Screen Shot 2021-01-06 at 18.42.24.png|width=603,height=272!
> Then there's the log,
> {code:java}
> client.TezClient: Shutting down Tez Session, sessionName= ....{code}
> !Screen Shot 2021-01-06 at 18.42.55.png|width=1372,height=26!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message