hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-25091) Implement connector provider for MSSQL and Oracle
Date Tue, 27 Jul 2021 14:29:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-25091?focusedWorklogId=628501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628501
]

ASF GitHub Bot logged work on HIVE-25091:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jul/21 14:28
            Start Date: 27/Jul/21 14:28
    Worklog Time Spent: 10m 
      Work Description: nrg4878 commented on a change in pull request #2248:
URL: https://github.com/apache/hive/pull/2248#discussion_r677504488



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java
##########
@@ -245,7 +248,12 @@ protected Connection getConnection() {
   private ResultSet fetchTablesViaDBMetaData(String regex) throws SQLException {
     ResultSet rs = null;
     try {
-      rs = getConnection().getMetaData().getTables(scoped_db, null, regex, new String[] {
"TABLE" });
+        if (this.type.equalsIgnoreCase(IDataConnectorProvider.ORACLE_TYPE) ||

Review comment:
       Sorry if I missed this earlier or if this was recently added, but would it make sense
to move this logic into the provider ? so the abstract provider will call something like getCatalog()
and getSchema() which will return whatever is appropriate. Maybe the abstract provider can
provide the default and providers can override the method. or maybe just add a util method
in this class (not abstract) that returns the values for all the DBs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 628501)
    Time Spent: 50m  (was: 40m)

> Implement connector provider for MSSQL and Oracle
> -------------------------------------------------
>
>                 Key: HIVE-25091
>                 URL: https://issues.apache.org/jira/browse/HIVE-25091
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sai Hemanth Gantasala
>            Assignee: Sai Hemanth Gantasala
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Provide an implementation of Connector provider for MSSQL and Oracle



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message