hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-25192) Nullify summary for non-native tables
Date Tue, 27 Jul 2021 14:54:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-25192?focusedWorklogId=628522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628522
]

ASF GitHub Bot logged work on HIVE-25192:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jul/21 14:53
            Start Date: 27/Jul/21 14:53
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2473:
URL: https://github.com/apache/hive/pull/2473#discussion_r677529993



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -2680,9 +2683,9 @@ public void run() {
                   total += estimator.estimate(jobConf, scanOp, -1).getTotalLength();
                 }
                 recordSummary(path, new ContentSummary(total, -1, -1));
-              } else {
-                // todo: should nullify summary for non-native tables,
-                // not to be selected as a mapjoin target
+              } else if (handler == null) {

Review comment:
       Thanks for the explanation and the patience! 😄 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 628522)
    Time Spent: 3h 10m  (was: 3h)

> Nullify summary for non-native tables
> -------------------------------------
>
>                 Key: HIVE-25192
>                 URL: https://issues.apache.org/jira/browse/HIVE-25192
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zhihua Deng
>            Assignee: Zhihua Deng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> When creating non-native tables like kudu, hbase and so on,  we create a warehouse location
for these tables, though these tables may not use the location to store data or for job plan,
we should skip getting the input summary of non-native tables when optimising joins,  as
which may cause oom problem when the non-native table is on the build side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message