hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-25342) Optimize set_aggr_stats_for for mergeColStats path.
Date Mon, 26 Jul 2021 03:08:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-25342?focusedWorklogId=627500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627500
]

ASF GitHub Bot logged work on HIVE-25342:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jul/21 03:07
            Start Date: 26/Jul/21 03:07
    Worklog Time Spent: 10m 
      Work Description: rbalamohan commented on a change in pull request #2489:
URL: https://github.com/apache/hive/pull/2489#discussion_r676262038



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -8976,8 +8981,12 @@ private boolean updatePartColumnStatsWithMerge(String catName, String
dbName, St
 
         if (!csNew.getStatsObj().isEmpty()) {
           // We don't short-circuit on errors here anymore. That can leave acid stats invalid.
-          result = updatePartitonColStatsInternal(t, csNew,
-              request.getValidWriteIdList(), request.getWriteId()) && result;
+          if (MetastoreConf.getBoolVar(getConf(), ConfVars.TRY_DIRECT_SQL)) {

Review comment:
       move this getConf computation out of the loop.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 627500)
    Time Spent: 20m  (was: 10m)

> Optimize set_aggr_stats_for for mergeColStats path. 
> ----------------------------------------------------
>
>                 Key: HIVE-25342
>                 URL: https://issues.apache.org/jira/browse/HIVE-25342
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: mahesh kumar behera
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The optimisation used for normal path to use direct sql can also be used for mergeColStats
> path. The stats to be updated can be accumulated in a temp list and that list can be
used to update the stats in a batch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message