ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Boudnik <...@apache.org>
Subject Re: Fwd: Coding Guidelines: zookeeper IP finder and mqtt streamer
Date Sun, 04 Oct 2015 08:39:46 GMT
On Fri, Oct 02, 2015 at 04:26PM, Anton Vinogradov wrote:
> Raul,
> 
> I've fixed most of TODOs you created.
> Seems that indentation policy with multi-line parameter descriptions
> already defined: "multiline comments in Javadoc tags should be indented by
> 4 or 5 characters ...".

That's a bit weird. Java style recommends 8, I believe. And a number of the
projects in Apache uses 2-4-4, which I personally find a better looking and
compact compared to the Java style. But 5?

Cos

> Please check my changes:
> https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=57901455&selectedPageVersions=16&selectedPageVersions=15
> 
> 
> 
> On Tue, Sep 29, 2015 at 3:28 PM, Roman Shaposhnik <roman@shaposhnik.org>
> wrote:
> 
> > On Tue, Sep 29, 2015 at 3:01 PM, Raul Kripalani <raul@evosent.com> wrote:
> > > Thanks, Cos. I'm glad we sorted this out. Sometimes a chat would be
> > useful
> > > to establish rapport.
> > >
> > > Accusing someone of negligence is *extremely* serious and casts a very
> > bad
> > > image on the person being attributed with it.
> >
> > I've been there and I understand where you're coming from. Different words
> > have different level of gravity in different languages and cultures.
> >
> > FWIW: I didn't read it as invoking catastrophic ramifications and/or
> > doubting
> > integrity of the person. But that's *my* reading. Somebody who, at the end
> > of
> > the day, speaks English fluently but alas as a second language. I do
> > apologize
> > if it made if you feel uncomfortable.
> >
> > I think the key takeaway for all of us who chimed in on this thread is
> > to be extremely
> > appreciative of the fact that we all come from different backgrounds
> > and cultures
> > and can interpret things differently. Lets give each other a bit of a
> > breathing
> > room and a benefit of the doubt.
> >
> > Thanks,
> > Roman.
> >

Mime
View raw message