ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexey Kuznetsov <akuznet...@gridgain.com>
Subject Re: Switching back to review-then-commit process
Date Thu, 03 Mar 2016 13:02:12 GMT
+1 from me. I could be a maintainer for following modules: visor-console,
schema-import-utility, ignite-web-console, scalar.

We could even copy-paste rules from Spark wiki to ours.

On Thu, Mar 3, 2016 at 6:54 PM, Denis Magda <dmagda@gridgain.com> wrote:

> Igniters,
>
> I would propose to switch back to review-then-commit process. This process
> has to be followed by both contributors and committers.
>
> There is a reason for this I have in mind. Ignite is a complex platform
> with several big modules. Some of the people may be experts in module A
> while others in module B etc.
> If a committer, who is good in module A, makes changes in module B merging
> the changes without a review this can break module's B internal
> functionality that the committer didn't take into account.
>
> My proposal is to introduce a list of maintainers for every Ignite module
> like it's done in Spark [1] and a rule that will require a committer to get
> an approval from a module maintainer before merging changes.
>
> Thoughts?
>
> --
> Denis
>
> [1]
> https://cwiki.apache.org/confluence/display/SPARK/Committers#Committers-ReviewProcessandMaintainers
>
>
>


-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message