ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sunny Chan, CLSA" <sunny.c...@clsa.com>
Subject Log level changes in GridCacheWriteBehindStore.updateStore
Date Mon, 26 Aug 2019 06:17:07 GMT
Hello,

In the GridCacheWriteBehindStore<https://github.com/apache/ignite/blob/7e73098d4d6e3d5f78326cb11dac7e083a2312dd/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/store/GridCacheWriteBehindStore.java#L893>,
when the updateStore failed to write to underlying store, it logs this as error:

LT.error(log, e, "Unable to update underlying store: " + store);

After this line logged the error, it would return false so that it would retry the store (by
returning false).

While later on in the updatStore function, when the writeCache overflows, it would log this:

log.warning("Failed to update store (value will be lost as current buffer size is greater
" + ...

then it will remove the failed entry.

I think the severity of the log messages is not right, as the fail update would still be retried.

So I propose to change the log severity level so that the first one would be a warn, and second
one would be error. Is that acceptable?

Sunny Chan
Senior Lead Engineer, Executive Services
D  +852 2600 8907  |  M  +852 6386 1835  |  T  +852 2600 8888
5/F, One Island East, 18 Westlands Road, Island East, Hong Kong

[:1. Social Media Icons:CLSA_Social Media Icons_linkedin.png]<https://hk.linkedin.com/company/clsa>[:1.
Social Media Icons:CLSA_Social Media Icons_twitter.png]<https://twitter.com/clsainsights?lang=en>[:1.
Social Media Icons:CLSA_Social Media Icons_youtube.png]<https://www.youtube.com/channel/UC0qWp_lLnOcRYmBlCNQgZKA>[:1.
Social Media Icons:CLSA_Social Media Icons_facebook.png]<https://www.facebook.com/clsacommunity/>

clsa.com<https://www.clsa.com/>
Insights. Liquidity. Capital.

[CLSA_RGB]<https://www.clsa.com/member>

A CITIC Securities Company

The content of this communication is intended for the recipient and is subject to CLSA Legal
and Regulatory Notices.
These can be viewed at https://www.clsa.com/disclaimer.html or sent to you upon request.
Please consider before printing. CLSA is ISO14001 certified and committed to reducing its
impact on the environment.

Mime
  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message