ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikolay Izhikov (Jira)" <j...@apache.org>
Subject [jira] [Created] (IGNITE-12406) Refactor GridCommonAbstractTest#findKeys to use enum
Date Fri, 29 Nov 2019 11:58:00 GMT
Nikolay Izhikov created IGNITE-12406:

             Summary: Refactor GridCommonAbstractTest#findKeys to use enum
                 Key: IGNITE-12406
                 URL: https://issues.apache.org/jira/browse/IGNITE-12406
             Project: Ignite
          Issue Type: Bug
            Reporter: Nikolay Izhikov

Currently, we have {{type}} argument in findKeys method.
It used to distinguish between required key types.
This argument should be refactored to enum and documented in JavaDoc.

    protected List<Integer> findKeys(@Nullable ClusterNode node, IgniteCache<?, ?>
        final int cnt, final int startFrom, final int type) {
                        if (type == 0)
                            ok = aff.isPrimary(node0, key);
                        else if (type == 1)
                            ok = aff.isBackup(node0, key);
                        else if (type == 2)
                            ok = !aff.isPrimaryOrBackup(node0, key);

This message was sent by Atlassian Jira

View raw message