ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ткаленко кирилл <tkalkir...@yandex.ru>
Subject Re: [DISCUSS] Ignite process exit code on node stop by failure handler
Date Tue, 02 Jun 2020 13:59:09 GMT
Hello, Alexey!

I didn't quite understand about merge. 

If we use StopNodeOrHaltFailureHandler with tryStop=true, then if we don't stop node by timeout,
we will terminate jvm.

Or do you suggest only stopping the node in StopNodeFailureHandler and terminate jvm in StopNodeOrHaltFailureHandler?
or leave it as it is?

02.06.2020, 16:46, "Alexey Goncharuk" <alexey.goncharuk@gmail.com>:
>>  > How exactly do you want to change the StopNodeFH?
>>  I want to stop JVM with KILL_EXIT_CODE and add an option (constructor
>>  argument of JVM option) for disabling JVM termination.
>
> When the flag is enabled, the behavior is identical to StopNodeOrHaltFH
> with tryStop=false. In other words,
> StopNodeFH with enabled JVM termination === StopNodeOrHaltFH with
> tryStop=false
> StopNodeFG with disabled JVM termination ~ StopNodeOrHaltFH with
> tryStop=true
>
> Why have two different failure handlers with identical behavior? Perhaps,
> there is confusion and we should consider merging these classes into one?

Mime
View raw message