ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Kuznetsov (Jira)" <j...@apache.org>
Subject [jira] [Created] (IGNITE-13104) Spring data 2.0 IgniteRepositoryImpl#deleteAllById contains wrong code
Date Mon, 01 Jun 2020 16:13:00 GMT
Alexey Kuznetsov created IGNITE-13104:
-----------------------------------------

             Summary: Spring data 2.0 IgniteRepositoryImpl#deleteAllById contains wrong code
                 Key: IGNITE-13104
                 URL: https://issues.apache.org/jira/browse/IGNITE-13104
             Project: Ignite
          Issue Type: Improvement
          Components: springdata
    Affects Versions: 2.8.1
            Reporter: Alexey Kuznetsov
            Assignee: Alexey Kuznetsov
             Fix For: 2.9


{code}
    /** {@inheritDoc} */
    @Override public void deleteAllById(Iterable<ID> ids) {
        if (ids instanceof Set)
            cache.removeAll((Set<ID>)ids);

        if (ids instanceof Collection)
            cache.removeAll(new HashSet<>((Collection<ID>)ids));

        TreeSet<ID> keys = new TreeSet<>();

        for (ID id : ids)
            keys.add(id);

        cache.removeAll(keys);
    }
{code}

As you can see cache.removeAll may be executed THREE times in some situations.
Also this method can throw ClassCast exception if ids collection contains objects that are
not implement Comparable interface.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message