jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-312) Use stable root from session in NodeTypeManagerImpl
Date Wed, 19 Sep 2012 11:20:07 GMT

    [ https://issues.apache.org/jira/browse/OAK-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458573#comment-13458573

Michael Dürig commented on OAK-312:

Patch looks good to me, didn't run the tests though.

However, it would be great if we could align the approaches taken for the name space registry
and the node type manager a bit more and at the same time come up with better class names.
In the case of the node type manager {{AbstractNodeTypeManager}} is an abstract base class
for read only implementations and {{NodeTypeManagerImpl}} is an abstract base class for r/w
implementations. I think the names should reflect that better.

For the name space registry we should follow the same pattern and provide abstract base classes
for read only and for r/w implementations. 

See also http://jackrabbit.markmail.org/message/csreb6l6pxylpig7
> Use stable root from session in NodeTypeManagerImpl
> ---------------------------------------------------
>                 Key: OAK-312
>                 URL: https://issues.apache.org/jira/browse/OAK-312
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, jcr
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>         Attachments: OAK-312.patch
> Similar to OAK-306, also the node type manager should be based on the same stable root
used in SessionDelegate.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message