jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-315) Separate built-in node types from ReadWriteNodeTypeManager
Date Wed, 19 Sep 2012 14:20:07 GMT

    [ https://issues.apache.org/jira/browse/OAK-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458710#comment-13458710
] 

Michael Dürig commented on OAK-315:
-----------------------------------

+1 for separating.

Moving the registration of built in node type to oak-jcr is also fine with me. However we
need to take care to do that while at the same time keeping registration as lazy as it is.
Note that access to the latest root creates a branch in the Microkernel. In the current implementation
this does not happen on login itself (*) but is deferred until the session is actually accessed.
This is also the point where the default node types are registered if not already present.


(*) the reason for this is the infamous repository pinger of Apache Sling. See also OAK-272.

                
> Separate built-in node types from ReadWriteNodeTypeManager
> ----------------------------------------------------------
>
>                 Key: OAK-315
>                 URL: https://issues.apache.org/jira/browse/OAK-315
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, jcr
>            Reporter: Marcel Reutegger
>            Priority: Minor
>
> Registration code for built-in node types are currently in ReadWriteNodeTypeManager.
I think this should be separate from the more generic node type management. Triggering the
registration in ContentSession also looks strange to me.
> I suggest we move the built-in node type registration to oak-jcr for now. I think oak-core
or more specifically ContentSession shouldn't have to know about built-in node types or plugins
in general.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message