jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-394) IndexManagerHook to manage existing indexes
Date Mon, 05 Nov 2012 10:50:12 GMT

    [ https://issues.apache.org/jira/browse/OAK-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490560#comment-13490560
] 

Alex Parvulescu commented on OAK-394:
-------------------------------------

A tiny update: I'm not happy with the way this works now, I think I missed some important
bits tied to the way diffs work.

The IndexManager gathers the IndexDefinitions first, then it passes them via the IndexHookProvider
to relevant IndexHook impls.
The problem here is that the NodeState that gets passed on is the index content node (ex:
"/oak:index/index"), when in fact it should be the repository node that needs to be indexed
(ex: "/").

Another problem is that recursing through the diffs doesn't work properly. Even if the IndexManager
succeeds in gathering all the index defs under certain paths, the path info is never used,
so triggering a full reindex can mean that "all" the index implementation (never mind the
location) will contain all the repository content. 
This is not a big problem now, as we only have a few index defs under the root.


                
> IndexManagerHook to manage existing indexes
> -------------------------------------------
>
>                 Key: OAK-394
>                 URL: https://issues.apache.org/jira/browse/OAK-394
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: indexmanager-commondiff.patch, indexmanager-commondiff-v2.patch,
indexmanager.patch
>
>
> The Index Manager is making a comeback!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message