jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-443) UserInitializer causes repository traversal
Date Wed, 23 Jan 2013 16:54:13 GMT

     [ https://issues.apache.org/jira/browse/OAK-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alex Parvulescu updated OAK-443:
--------------------------------

    Attachment: OAK-443.patch

attaching proposed patch.

There are 2 important parts of this patch:

1. The MemoryNodeStore now takes a CommitHook and the branch will run the hooks on #merge.
This is pretty standalone and it could go into trunk by itself.

2. The UserInitializer will now use a Root instance that has both a Property2IndexProvider
hardcoded as well as a Property2IndexHookProvider.
This will allow the code to create/update the query index & use it for the user facing
queries.

All tests pass but everything extending AbstractSecurityTest doesn't use any kind of indexes
for the tests.
I would have liked to add the p2 ones (Property2IndexHookProvider, Property2IndexProvider)
to the tests but then some of them start failing (the ExternalLoginModuleTest and another
one).
I don't think that is a problem, but I thought it's work mentioning anyway.

As an aside note I'm wondering why there is no way of getting a NodeState from a Root or a
Tree.

Feedback appreciated.

The patch is based on OAK-410 work.
                
> UserInitializer causes repository traversal
> -------------------------------------------
>
>                 Key: OAK-443
>                 URL: https://issues.apache.org/jira/browse/OAK-443
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Marcel Reutegger
>         Attachments: OAK-443.patch
>
>
> UserInitializer operates on a RootImpl without QueryIndexProvider, which results in a
traversal of the complete content when an authorizable is looked up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message