jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-549) PropertyLocation#remove not part of TreeLocation API
Date Thu, 10 Jan 2013 16:44:14 GMT

    [ https://issues.apache.org/jira/browse/OAK-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549780#comment-13549780
] 

Michael Dürig commented on OAK-549:
-----------------------------------

Yes, makes sense. +1 for the patch.
                
> PropertyLocation#remove not part of TreeLocation API
> ----------------------------------------------------
>
>                 Key: OAK-549
>                 URL: https://issues.apache.org/jira/browse/OAK-549
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>         Attachments: OAK-549.patch
>
>
> In order to remove a property without having to access the
> parent node can be achieved by PropertyLocation#remove(). however,
> this method is not part of the TreeLocation API and thus oak-jcr
> needs to cast the location associated with a given property to
> TreeImpl#PropertyLocation.
> I would suggest to expose that method in the TreeLocation interface
> as the implementation was straight forward for all implementations.
> Alternatively, if that's not acceptable i think we should split the
> TreeLocation interface into a property and a node variant and add the
> remove method the property-location only.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message