jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-568) Duplicated code in TreeLocation implementations
Date Fri, 18 Jan 2013 16:18:12 GMT

    [ https://issues.apache.org/jira/browse/OAK-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557320#comment-13557320
] 

Michael Dürig commented on OAK-568:
-----------------------------------

I thought about something along these lines when I implemented those. However, given the factored
out code is pretty trivial I decided to duplicate it in favour of not adding another set of
classes along with the additional complexity introduced (e.g. by type parametrisation). 

The patch looks good otherwise AFAICT. Overall I'm +/-0 for applying it. 
                
> Duplicated code in TreeLocation implementations
> -----------------------------------------------
>
>                 Key: OAK-568
>                 URL: https://issues.apache.org/jira/browse/OAK-568
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>         Attachments: OAK-568.patch
>
>
> see proposed patch to get rid of the duplicated code in the 4 implementations
> of TreeLocation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message