jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-1056) Transient changes contributed by commit hooks are kept in memory
Date Fri, 04 Apr 2014 09:30:16 GMT

    [ https://issues.apache.org/jira/browse/OAK-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959803#comment-13959803
] 

Michael Dürig commented on OAK-1056:
------------------------------------

Thanks Marcel for taking care of this. Your fix applies to {{DocumentNodeStore}} only and
not to {{KernelNodeStore}} right? I think this is fine and we can leave this as a known issue
for the latter as we now know how we can fix it if the need should arise. 

> Transient changes contributed by commit hooks are kept in memory
> ----------------------------------------------------------------
>
>                 Key: OAK-1056
>                 URL: https://issues.apache.org/jira/browse/OAK-1056
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>            Assignee: Marcel Reutegger
>            Priority: Blocker
>             Fix For: 0.20
>
>         Attachments: OAK-1056.patch, OAK-1056.patch
>
>
> With the {{KernelNodeStore}}, transient changes contributed by commit hooks are currently
kept in memory instead of being written ahead to the private branch. The reason for this is
that we need to be able to undo such changes if a commit hook later in the process fails the
commit. Doing this efficiently would need some support from the persistent layer. Either the
ability for branching from a branch or the ability to roll back to a previous state. 
> See the TODOs in {{KernelNodeState.builder()}}, which returns a MemoryNodeBuilder (instead
of a KernelNodeBuilder when the current state is on a branch. This is the workaround to avoid
branching form a branch and has the effect that commit hooks currently run against a MemoryNodeBuilder
and limits the amount of changes commit hooks can add.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message