jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-2828) Jcr builder class does not allow overriding most of its dependencies
Date Mon, 10 Aug 2015 12:28:45 GMT

    [ https://issues.apache.org/jira/browse/OAK-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680029#comment-14680029
] 

Alex Parvulescu commented on OAK-2828:
--------------------------------------

why not let the defaults in anyway. basically keep the current constructor as it was before
the patch, which will only provide an initial provisioning of all components. next, if you
need new stuff, you can always use the _with_ methods.

> Jcr builder class does not allow overriding most of its dependencies
> --------------------------------------------------------------------
>
>                 Key: OAK-2828
>                 URL: https://issues.apache.org/jira/browse/OAK-2828
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: jcr
>    Affects Versions: 1.2.2
>            Reporter: Robert Munteanu
>            Assignee: Francesco Mari
>              Labels: modularization, technical_debt
>             Fix For: 1.3.5
>
>         Attachments: 0001-OAK-2828-Jcr-builder-class-does-not-allow-overriding.patch
>
>
> The {{Jcr}} class is the entry point for configuring a JCR repository using an Oak backend.
However, it always use a hardcoded set of dependencies ( IndexEditorProvider, SecurityProvider,
etc )  which cannot be reset, as they are defined in the constructor and the builder {{with}}
methods eagerly configure the backing {{Oak}} instance with those dependencies.
> As an example
> {code:java|title=Jcr.java}
>     @Nonnull
>     public final Jcr with(@Nonnull SecurityProvider securityProvider) {
>         oak.with(checkNotNull(securityProvider));
>         this.securityProvider = securityProvider;
>         return this;
>     }
> {code}
> injects the security provider which in turn starts configuring the Oak repository provider
> {code:java|title=Oak.java}
>     @Nonnull
>     public Oak with(@Nonnull SecurityProvider securityProvider) {
>         this.securityProvider = checkNotNull(securityProvider);
>         if (securityProvider instanceof WhiteboardAware) {
>             ((WhiteboardAware) securityProvider).setWhiteboard(whiteboard);
>         }
>         for (SecurityConfiguration sc : securityProvider.getConfigurations()) {
>             RepositoryInitializer ri = sc.getRepositoryInitializer();
>             if (ri != RepositoryInitializer.DEFAULT) {
>                 initializers.add(ri);
>             }
>         }
>         return this;
>     }
> {code}
> Instead, the {{Jcr}} class should store the configured dependencies and only configure
the {{Oak}} instance when {{createRepository}} is invoked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message