jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-2973) [Blob GC] Report accurate deleted count
Date Wed, 05 Aug 2015 05:28:04 GMT

    [ https://issues.apache.org/jira/browse/OAK-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654841#comment-14654841

Chetan Mehrotra commented on OAK-2973:

Change looks fine. 

However bumping major version might pose a problem. May be we should mark the {{MarkAndSweekGarbageCollector}}
with provider type. However it might still result in major version change as return type is
being changed. Worst case we might need to provide a new method and let old method delegate
to that (in AsbtractBlobStore) and make use of new method

> [Blob GC] Report accurate deleted count
> ---------------------------------------
>                 Key: OAK-2973
>                 URL: https://issues.apache.org/jira/browse/OAK-2973
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>             Fix For: 1.3.5
>         Attachments: OAK-2973.patch
> Currently, the underlying data stores do not report the actual count deleted from the
candidate set in the {{GarbageCollectableBlobStore#deleteChunks}} method as there may be blobs
not satisfying the max last modified criteria. 
> For debugging it would be better to support returning the actual deleted count so that
{{MarkSweepGarbageCollector}} can accurately report the count of blobs deleted.

This message was sent by Atlassian JIRA

View raw message