jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Richard (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3153) Make it possible to disable recording of stack trace in SessionStats
Date Mon, 03 Aug 2015 07:20:04 GMT

    [ https://issues.apache.org/jira/browse/OAK-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651538#comment-14651538
] 

Joel Richard commented on OAK-3153:
-----------------------------------

I have discussed this issue with [~tmueller] and he didn't like the idea to make it possible
disabling it in general because then you cannot easily find session leaks anymore. One option
would be to keep track of the number of long living sessions and if they keep increasing enable
this option automatically. However, I don't know if it's worth that much effort. [~tmueller],
what do you think?

The ideal solution would be an API like 

{code}
repository.login(credentials, new WithSession() {
	doDork(Session session) {

	}
})
{code}

but this is very unlikely an option and it wouldn't even solve our particular problem because
there we use SlingRepository.

> Make it possible to disable recording of stack trace in SessionStats
> --------------------------------------------------------------------
>
>                 Key: OAK-3153
>                 URL: https://issues.apache.org/jira/browse/OAK-3153
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.3
>            Reporter: Joel Richard
>              Labels: performance
>
> For the rendering of some pages we have to create a lot of sessions. Around 9% of the
rendering time is spent inside of RepositoryImpl.login. Half of this time is spent creating
the exception in SessionStats. Therefore, it would be useful if the recording of the exception
could be disabled to improve the performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message