jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3174) [Blob GC] Make actual deletion of blobs synchronous
Date Wed, 05 Aug 2015 05:21:04 GMT

    [ https://issues.apache.org/jira/browse/OAK-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654836#comment-14654836
] 

Chetan Mehrotra commented on OAK-3174:
--------------------------------------

+1 patch looks fine. Not sure if we can add a test for this change. May be add a collecting
executor and assert about no of jobs it get for a given GC scenario

> [Blob GC] Make actual deletion of blobs synchronous
> ---------------------------------------------------
>
>                 Key: OAK-3174
>                 URL: https://issues.apache.org/jira/browse/OAK-3174
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: blob
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>              Labels: candidate_oak_1_0, candidate_oak_1_2
>             Fix For: 1.2.4, 1.3.4, 1.0.19
>
>         Attachments: OAK-3174.patch
>
>
> {{MarkSweepGarbageCollector#sweep}} at present tries to send concurrent batched requests
for blob ids to be deleted. This will present a problem if too many concurrent requests are
sent to the mongo/rdb exhausting the connection pool. 
> Also, there is a problem that the sweep returns without waiting for all the multiple
executors to finish execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message