jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (OAK-3201) Use static references in SecurityProviderImpl for composite services
Date Mon, 07 Sep 2015 09:42:47 GMT

     [ https://issues.apache.org/jira/browse/OAK-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Marcel Reutegger reopened OAK-3201:
-----------------------------------

Please set a fix version when you resolve an issue.

This change also introduced a regression and fails a test in oak-pojosr:

{noformat}
jmxIntegration(org.apache.jackrabbit.oak.run.osgi.MBeanIntegrationTest)  Time elapsed: 0.485
sec  <<< FAILURE!
Assertion failed: 

assert mbeans.size() == 1
       |      |      |
       |      2      false
       [org.apache.jackrabbit.oak.management.RepositoryManager[org.apache.jackrabbit.oak:name="repository
manager",type="RepositoryManagement",id=168], org.apache.jackrabbit.oak.management.RepositoryManager[org.apache.jackrabbit.oak:name="repository
manager",type="RepositoryManagement",id=161]]
{noformat}

> Use static references in SecurityProviderImpl for composite services
> --------------------------------------------------------------------
>
>                 Key: OAK-3201
>                 URL: https://issues.apache.org/jira/browse/OAK-3201
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>         Attachments: OAK-3201-01.patch, OAK-3201-02.patch
>
>
> {{SecurityProviderImpl}} has dynamic references to many other services, like {{RestrictionProvider}},
that represent the configuration of this component.
> Being these services dynamic, the OSGi runtime has no clear dependency relationship between
the {{SecurityProviderImpl}} and the required services. Thus, it may happen that an instance
of {{SecurityProviderImpl}} is published before the services it requires are started, creating
a window where the {{SecurityProviderimpl}} is operating differently from the way it's configured.
> I suggest to turn the dynamic references in {{SecurityProviderImpl}} to static ones to
improve the consistency of the implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message