jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3361) Reduce PerfLogger isDebugEnabled overhead
Date Mon, 07 Sep 2015 11:27:46 GMT

    [ https://issues.apache.org/jira/browse/OAK-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733565#comment-14733565
] 

Chetan Mehrotra commented on OAK-3361:
--------------------------------------

[~mreutegg] Can you have a look 

> Reduce PerfLogger isDebugEnabled overhead
> -----------------------------------------
>
>                 Key: OAK-3361
>                 URL: https://issues.apache.org/jira/browse/OAK-3361
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.4
>            Reporter: Joel Richard
>            Priority: Minor
>              Labels: performance
>         Attachments: 0001-OAK-3361-Reduce-PerfLogger-isDebugEnabled-overhead.patch
>
>
> If a node is cached, 1/4 of the time which is used to call DocumentNodeStore.getNode
is spent in PerfLogger.start and PerfLogger.end just for checking whether or not debug logging
is enabled (this is likely much less if no TurboFilters are used).
> To reduce the overhead of the PerfLogger, it should not check if debug is enabled in
end() if start is below 0 anyway. Moreover, it would help to check only every second if debug
is really enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message