jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davide Giannella (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3371) Wrong evaluation of NOT clause
Date Fri, 11 Sep 2015 10:10:48 GMT

    [ https://issues.apache.org/jira/browse/OAK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740522#comment-14740522

Davide Giannella commented on OAK-3371:


bq. I don't like the "instanceof" check there. I think it's possible to avoid it, or move
it to the "simplify" method.

I don't like it either but didn't find any other way so far. I thought as well of the simplify
but didn't actually try it out.

bq. The method name "restrictPropertyOnFilter": it seems to be unnecessary, as the same can
be done using "enforcePropertyExistence".

missed this one.

bq. I will try to work on the patch and upload a new one.

Waiting for it. In the meantime I'm looking more in details at the test coverage as it's not
convincing me 100%.

> Wrong evaluation of NOT clause
> ------------------------------
>                 Key: OAK-3371
>                 URL: https://issues.apache.org/jira/browse/OAK-3371
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>    Affects Versions: 1.2.4, 1.3.5
>            Reporter: Davide Giannella
>            Assignee: Davide Giannella
>             Fix For: 1.3.6
>         Attachments: OAK-3371-2.patch, OAK-3371-test.diff, OAK-3371.patch
> When executing a query like 
> {noformat}
> {noformat}
> and the {{nodeType}} index plays the not clause is not applied properly. Nodes **with**
the property are returned as well.
> [test|^OAK-3371-test.diff] showing the bug.

This message was sent by Atlassian JIRA

View raw message