jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3412) Node name having non space whitspace chars should not be allowed
Date Thu, 24 Sep 2015 06:17:04 GMT

    [ https://issues.apache.org/jira/browse/OAK-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905883#comment-14905883
] 

Chetan Mehrotra commented on OAK-3412:
--------------------------------------

bq. although I'd prefer if we could avoid the configuration part.

Just to be clear by default node name with non space whitespace would not be allowed. Config
is just to enable old behaviour if this change causes problem for some setup. Would that be
ok ... or should I just provide a system property to revert to old behaviour

> Node name having non space whitspace chars should not be allowed
> ----------------------------------------------------------------
>
>                 Key: OAK-3412
>                 URL: https://issues.apache.org/jira/browse/OAK-3412
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.3.7, 1.2.7, 1.0.22
>
>         Attachments: OAK-3412.patch
>
>
> Due to the changes done in OAK-1174 node with non space whitespace chars like '\n', '\r'
etc can be created. This is not desirable and also JR2 does not allow such node to be created
so check must be added to prevent such a name from getting created.
> As discussed in [1] this is regression due to usage of incorrect utility method as part
of [2] the fix can be simply using a {{Character#isWhitespace}} instead of {{Character#isSpaceChar}}
> [1] http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201509.mbox/%3CCAHCW-mkkGtxkn%2B9xfXuvMTfgykewjMPsLwrVH%2B00%2BXaBQjA0sg%40mail.gmail.com%3E
> [2] https://github.com/apache/jackrabbit-oak/commit/342809f7f04221782ca6bbfbde9392ec4ff441c2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message