jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Teodor Rosu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3791) Time measurements for DocumentStore methods
Date Thu, 14 Jan 2016 08:46:39 GMT

    [ https://issues.apache.org/jira/browse/OAK-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097834#comment-15097834

Teodor Rosu commented on OAK-3791:

IMO timing the database related methods would be very useful. Is a timer costly? I expect
the DocumentStore methods that hit the database to be quite expensive ( order >= milliseconds
). I needed, I could spend some time investigating the impact.

One idea that might apply to other cases: if a timer adds overhead, a better option would
be to track “rates” and use random sampling with timers ( ex: time a method only 20% of
the calls ). This can still give a good idea of what happens in a system. 

On the long run having a lot of stats will add overhead. One other thing that might help would
be to add a state to a metric ( active/inactive ). To be more exact, oak will have (many)
stats added in all essential places. An “inactive” Stat will basically translate to a
noop.  By default all oak stats are “inactive”. Unless activated (somehow statically or
dynamically: configuration, osgi, system property etc) a metric should not add overhead. 

/cc [~chetanm] [~reschke] [~mreutegg]

> Time measurements for DocumentStore methods
> -------------------------------------------
>                 Key: OAK-3791
>                 URL: https://issues.apache.org/jira/browse/OAK-3791
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, documentmk
>            Reporter: Teodor Rosu
>            Assignee: Chetan Mehrotra
>             Fix For: 1.4
>         Attachments: OAK-3791-RDB-0.patch, OAK-3791-v1.patch
> For monitoring ( in big latency environments ), it would be useful to measure and report
time for the DocumentStore methods.
> These could be exposed as (and/or):
> - as Timers generated obtained from StatisticsProvider ( statistics registry )
> - as TimeSeries 

This message was sent by Atlassian JIRA

View raw message