jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-3862) Move integration tests in a different Maven module
Date Wed, 13 Jan 2016 13:02:39 GMT

    [ https://issues.apache.org/jira/browse/OAK-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096142#comment-15096142

Michael Dürig commented on OAK-3862:

Same here. Moving toward an dedicated IT module makes sense as this makes it more explicit
what are ITs that can run against various implementations and what are UTs for a specific
implementation. The ServiceLoader approach also looks promising but AFAICS there is too many
bits and pieces to get right to make it work making it too hard to understand how to add new
tests and how to maintain this going forward. 

> Move integration tests in a different Maven module
> --------------------------------------------------
>                 Key: OAK-3862
>                 URL: https://issues.apache.org/jira/browse/OAK-3862
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.4
> While moving the Segment Store and related packages into its own bundle, I figured out
that integration tests contained in {{oak-core}} contribute to a cyclic dependency between
the (new) {{oak-segment}} bundle and {{oak-core}}.
> The dependency is due to the usage of {{NodeStoreFixture}} to instantiate different implementations
of {{NodeStore}} in a semi-transparent way.
> Tests depending on {{NodeStoreFixture}} are most likely integration tests. A clean solution
to this problem would be to move those integration tests into a new Maven module, referencing
the API and implementation modules as needed.

This message was sent by Atlassian JIRA

View raw message