jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-3869) Refactor RecordWriter.write to always return a RecordId
Date Tue, 12 Jan 2016 20:13:39 GMT

    [ https://issues.apache.org/jira/browse/OAK-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094832#comment-15094832
] 

Michael Dürig commented on OAK-3869:
------------------------------------

bq. losing some type safety
Right. Though we never had the that kind of type safety for the other record types (i.e. list
records) neither. So to address the type safety aspect we could still return a {{RecordId}}
from the {{write}} method but parametrise {{RecordWriter}} on the record types (i.e. MapRecord,
ListRecord, etc.). Will give it a shot.

bq. what the change is actually for
It would have helped me to address OAK-3864 in a certain way. However I gave up on this. See
comments there. OTOH it might also help to simplify tracking free segments in OAK-3348 (See
https://github.com/mduerig/jackrabbit-oak/commits/OAK-3348). This is still early draft state
so there is no hurry here.

> Refactor RecordWriter.write to always return a RecordId
> -------------------------------------------------------
>
>                 Key: OAK-3869
>                 URL: https://issues.apache.org/jira/browse/OAK-3869
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>
> I think it would be cleaner if {{RecordId.write}} would always return a {{RecordId}}
instead of depending on its type parametrisation and would like to refactor it to that respect..

> This is also a pre-requisite for my work on OAK-3348 and might also be for OAK-3864.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message