jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davide Giannella (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (OAK-3877) PerfLogger should use System.nanoTime instead of System.currentTimeMillis
Date Fri, 22 Jan 2016 09:21:41 GMT

     [ https://issues.apache.org/jira/browse/OAK-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Davide Giannella closed OAK-3877.
---------------------------------

Bulk close for 1.3.14

> PerfLogger should use System.nanoTime instead of System.currentTimeMillis
> -------------------------------------------------------------------------
>
>                 Key: OAK-3877
>                 URL: https://issues.apache.org/jira/browse/OAK-3877
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.3.14
>
>
> PerfLogger currently make use of System.currentTimeMillis for timing the performance.
It would be better to make use of System.nanoTime.
> Per [~ianeboston] [comment|https://issues.apache.org/jira/browse/OAK-3654?focusedCommentId=15022031&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15022031]
and [1]
> bq. You should always try to use nanoTime to do timing measurement or calculation
> This would provide following benefits
> * Simpler integration with Metric stats support which makes use of nanoTime
> * No possibility of drift i.e. currentTimeMillis going back in time
> [1] https://blogs.oracle.com/dholmes/entry/inside_the_hotspot_vm_clocks



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message