jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3942) Convert tests for TreeLocation and ImmutableTree to regular unit tests
Date Thu, 28 Jan 2016 13:01:39 GMT

    [ https://issues.apache.org/jira/browse/OAK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121377#comment-15121377
] 

angela commented on OAK-3942:
-----------------------------

not really... afaik they really just tested the implementation and were extending {{OakBaseTest}}
because that was a existing base that with some minimal setup.

> Convert tests for TreeLocation and ImmutableTree to regular unit tests
> ----------------------------------------------------------------------
>
>                 Key: OAK-3942
>                 URL: https://issues.apache.org/jira/browse/OAK-3942
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, it
>            Reporter: angela
>            Assignee: angela
>             Fix For: 1.3.15
>
>
> while moving out all IT test into a separate module, {{ImmutableTreeTest}} and {{TreeLocationTest}}
got moved because they extended from {{OakBaseTest}}. IMO however, they are just regular unit
tests that don't need to be run against various fixtures... as discussed with [~frm] they
most probably became ITs by mistake not because they actually are ITs.
> I will therefore move them back to {{oak-core}} and refactor to regular unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message