jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3952) BackgroundObserver close should wait for stop to be processed
Date Fri, 29 Jan 2016 07:13:39 GMT

    [ https://issues.apache.org/jira/browse/OAK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123113#comment-15123113
] 

Chetan Mehrotra commented on OAK-3952:
--------------------------------------

[~mduerig] [~mmarth] Should we do it for 1.4. I would try to come up with a patch for this

> BackgroundObserver close should wait for stop to be processed
> -------------------------------------------------------------
>
>                 Key: OAK-3952
>                 URL: https://issues.apache.org/jira/browse/OAK-3952
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.4
>
>
> {{BackgroundObserver}} close method currently says that it does not wait for thread to
finish. This can lead to situation when during shutdown the backing {{NodeStore}} goes away
while the background thread is still busy with diff and that would lead to exceptions in the
log.
> As being done in OAK-3923 the close call should wait for {{STOP}} signal to be processed
before returning from close call.
> On side note we should also provide an option where the close call should wait for the
queue to be processed instead of just silently clearing the queue which can lead to potential
loss of important local events. Note that can happen for proper ordered shutdown!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message