jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francesco Mari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4105) Implement FileStore.size through FileStore.approximateSize
Date Tue, 08 Mar 2016 21:10:40 GMT

    [ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185801#comment-15185801
] 

Francesco Mari commented on OAK-4105:
-------------------------------------

I don't see why not, since {{approximateSize}} is a tight approximation of the real size of
the repository. I'm not aware of any issue with this approach, so I'm in favour of it.

> Implement FileStore.size through FileStore.approximateSize
> ----------------------------------------------------------
>
>                 Key: OAK-4105
>                 URL: https://issues.apache.org/jira/browse/OAK-4105
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Priority: Minor
>              Labels: resilience
>             Fix For: 1.6
>
>
> {{FileStore.size()}} is prone to lock contention and should not be called too often.
As OAK-2879 already introduced an approach for tracking the current size of the file store
without having to lock, we might as well promote his to be "the official" implementation.

> [~frm] WDYT?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message