jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3361) Reduce PerfLogger isDebugEnabled overhead
Date Tue, 12 Jul 2016 13:25:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372868#comment-15372868
] 

Vikas Saurabh commented on OAK-3361:
------------------------------------

Backported to 1.2 in [r1752289|https://svn.apache.org/r1752289].

> Reduce PerfLogger isDebugEnabled overhead
> -----------------------------------------
>
>                 Key: OAK-3361
>                 URL: https://issues.apache.org/jira/browse/OAK-3361
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.4
>            Reporter: Joel Richard
>            Assignee: Marcel Reutegger
>            Priority: Minor
>              Labels: candidate_oak_1_0, performance
>             Fix For: 1.4, 1.3.6, 1.2.17
>
>         Attachments: 0001-OAK-3361-Reduce-PerfLogger-isDebugEnabled-overhead.patch
>
>
> If a node is cached, 1/4 of the time which is used to call DocumentNodeStore.getNode
is spent in PerfLogger.start and PerfLogger.end just for checking whether or not debug logging
is enabled (this is likely much less if no TurboFilters are used).
> To reduce the overhead of the PerfLogger, it should not check if debug is enabled in
end() if start is below 0 anyway. Moreover, it would help to check only every second if debug
is really enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message