jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrei Dulceanu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-4105) Implement FileStore.size through FileStore.approximateSize
Date Fri, 15 Jul 2016 11:41:20 GMT

     [ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Andrei Dulceanu updated OAK-4105:
    Attachment: OAK-4105-01.patch

I changed the {{FileStore.size()}} implementation to use {{approximateSize}}. This is initialised
once during {{FileStore}} creation by calling {{FileStore.initialSize()}} which mirrors the
old implementation (locks FileStore and iterates over all tar files, getting their respective

I attached the patch. [~frm] Could you take a look at it?

> Implement FileStore.size through FileStore.approximateSize
> ----------------------------------------------------------
>                 Key: OAK-4105
>                 URL: https://issues.apache.org/jira/browse/OAK-4105
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: resilience
>             Fix For: Segment Tar 0.0.6
>         Attachments: OAK-4105-01.patch
> {{FileStore.size()}} is prone to lock contention and should not be called too often.
As OAK-2879 already introduced an approach for tracking the current size of the file store
without having to lock, we might as well promote his to be "the official" implementation.

> [~frm] WDYT?

This message was sent by Atlassian JIRA

View raw message