jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Commented] (OAK-4105) Implement FileStore.size through FileStore.approximateSize
Date Wed, 20 Jul 2016 14:14:20 GMT

    [ https://issues.apache.org/jira/browse/OAK-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385916#comment-15385916
] 

Michael Dürig commented on OAK-4105:
------------------------------------

[~dulceanu], I had a quick chat with [~frm] and we agreed that most likely the best course
of action would be to get rid of the approximate size feature and improve the size calculation
itself as indicated in my previous comment. As the {{size()}} method is only used from {{FileStore}}
itself and some tests it would be best to lower its visibility to package. This would prevent
it from being misused (e.g. called every second from some monitoring tool). If we later on
need such monitoring we can still build it on top of the package private method ensuring we
call the method not too often by returning cached values in the mean time. 

If you agree please resolve this issue as won't fix and open a new one.

> Implement FileStore.size through FileStore.approximateSize
> ----------------------------------------------------------
>
>                 Key: OAK-4105
>                 URL: https://issues.apache.org/jira/browse/OAK-4105
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: resilience
>             Fix For: Segment Tar 0.0.6
>
>         Attachments: OAK-4105-01.patch, OAK-4105-02.patch
>
>
> {{FileStore.size()}} is prone to lock contention and should not be called too often.
As OAK-2879 already introduced an approach for tracking the current size of the file store
without having to lock, we might as well promote his to be "the official" implementation.

> [~frm] WDYT?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message