jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-4567) Define oak:Resource nodetype as non referenceable alternative to nt:resource
Date Tue, 19 Jul 2016 13:53:20 GMT

     [ https://issues.apache.org/jira/browse/OAK-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

angela updated OAK-4567:
    Attachment: OAK-4567-v2.patch

[~chetanm], just a few minor nitpicking comments regarding the patch (see v2 atttached):

- i would not replace nt:resource in the description of nt:file but just mention the alternative
as well
- i would add a constant for oak:Resource to {{NodeTypeConstant}} and use it in the tests
(along with constants for the other predefined names)
- i would mention {{oak:Resource}} in the documentation to make sure it gets some visibility...
i am sure you can come up with a better phrasing here...

> Define oak:Resource nodetype as non referenceable alternative to nt:resource
> ----------------------------------------------------------------------------
>                 Key: OAK-4567
>                 URL: https://issues.apache.org/jira/browse/OAK-4567
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.6
>         Attachments: OAK-4567-v1.patch, OAK-4567-v2.patch
> In most cases where code uses JcrUtils.putFile [1] it leads to
> creation of below content structure
> {noformat}
> + foo.jpg (nt:file)
>    + jcr:content (nt:resource)
>        - jcr:data
> {noformat}
> Due to usage of nt:resource each nt:file node creates a entry in uuid
> index as nt:resource is referenceable. So if a system has 1M
> nt:file nodes then we would have 1M entries in /oak:index/uuid as in
> most cases the files are created via [1] and hence all such files are
> referenceable
> The nodetype defn for nt:file does not mandate that the
> requirement for jcr:content being nt:resource. To support such non referenceable files
we would define a new nodeType similar to nt:resource but which is non referenceable.
> See [2] for related discussion
> [1] https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/commons/JcrUtils.java#L1062
> [2] http://jackrabbit-oak.markmail.org/thread/qicpzm5ltnzfsd42

This message was sent by Atlassian JIRA

View raw message