jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (JIRA) <j...@apache.org>
Subject [jira] [Updated] (OAK-4570) Base node states should be reused across generations
Date Tue, 19 Jul 2016 13:12:20 GMT

     [ https://issues.apache.org/jira/browse/OAK-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Michael Dürig updated OAK-4570:
    Attachment: OAK-4570-02.patch

Interesting discovery! I like the patch as it makes the code more uniform.

Digging a bit deeper this also uncovered an issue with non modified properties already present
in the base state not being reused after compaction. In [^OAK-4570-02.patch] I extended the
test case to also cover this and fixed property serialisation accordingly. 

I also renamed {{getCompactedRecordId()}} to {{deduplicateNode()}} and added a bit of comment.

[~frm], please review. 

> Base node states should be reused across generations
> ----------------------------------------------------
>                 Key: OAK-4570
>                 URL: https://issues.apache.org/jira/browse/OAK-4570
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: Segment Tar 0.0.6
>         Attachments: OAK-4570-01.patch, OAK-4570-02.patch
> When committing a {{SegmentNodeBuilder}} obtained from a {{SegmentNodeState}} belonging
to a previous generation, base node states should be reused if they were previously compacted.
> This avoids the complete rewrite of templates and property maps. If those records can
be obtained from a compacted base node state, they should just be referenced and reused.

This message was sent by Atlassian JIRA

View raw message