jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Francesco Mari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4396) HttpStore.containsSegment throws SNFE instead of returning false for non existing segments
Date Tue, 01 Nov 2016 16:03:58 GMT

    [ https://issues.apache.org/jira/browse/OAK-4396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625808#comment-15625808
] 

Francesco Mari commented on OAK-4396:
-------------------------------------

[~mduerig] I don't know if this issue is actually an issue. I think that the HttpStore could
be safely removed. I couldn't spot any usage of the HttpStore and I'm not aware of any user
of that implementation outside of Oak.

> HttpStore.containsSegment throws SNFE instead of returning false for non existing segments
> ------------------------------------------------------------------------------------------
>
>                 Key: OAK-4396
>                 URL: https://issues.apache.org/jira/browse/OAK-4396
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Francesco Mari
>            Priority: Minor
>
> That method tries to check existence of a segment by checking the return value of {{readSegment}}
for {{null}}. However, this method never returns {{null}} but throws a {{SNFE}} for non existing
segments. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message