jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (OAK-5557) incomplete diffManyChildren during commitHook evaluation in a persisted branch
Date Thu, 02 Feb 2017 12:36:51 GMT

     [ https://issues.apache.org/jira/browse/OAK-5557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Marcel Reutegger updated OAK-5557:
    Attachment: OAK-5557-1.2.patch

The attached patch [^OAK-5557-1.2.patch] looks at the two revisions to compare and also takes
the base revision of a potential branch in account to calculate the {{minTimestamp}}. With
this change, the test succeeds on the current 1.2 branch.

> incomplete diffManyChildren during commitHook evaluation in a persisted branch
> ------------------------------------------------------------------------------
>                 Key: OAK-5557
>                 URL: https://issues.apache.org/jira/browse/OAK-5557
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>    Affects Versions: 1.2.14, 1.2.23
>         Environment: 'easily' reproducible on 1.2.14
> 'takes longer to' reproduce on 1.2.23
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>         Attachments: DocumentNodeStoreBranchesTest.java, DocumentNodeStoreBranchesTest.java,
> In oak 1.2 when doing a diffManyChildren as part of running the CommitHooks as part of
a branch commit, not all child paths are taken into account in some cases.
> The problem seems to be related to the [{{_modified}} calculation|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.2.14/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java#L2242]
when doing the query for affected child paths. It seems [that {{minValue}}|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.2.14/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java#L2242]
is not correctly calculated when doing {{compareAgainstBaseState}} as part of a persisted
> Note that the problem can be reproduced very good on 1.2.14, less good but still on the
latest 1.2 and not in trunk (ie almost 1.6.0).
> Attaching a test case to reproduce

This message was sent by Atlassian JIRA

View raw message