jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5626) ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and commit-rate-limiter is null
Date Fri, 17 Feb 2017 07:17:41 GMT

    [ https://issues.apache.org/jira/browse/OAK-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871319#comment-15871319
] 

Julian Reschke commented on OAK-5626:
-------------------------------------

[~catholicon] - are you aware of the test failures, such as https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/1429/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.7%20(latest),nsfixtures=SEGMENT_TAR,profile=unittesting/testReport/junit/org.apache.jackrabbit.oak.jcr.observation/ObservationQueueFullWarnTest/warnOnRepeatedQueueFull_MemoryNodeStore_/

> ChangeProcessor doesn't reset 'blocking' flag when items from queue gets removed and
commit-rate-limiter is null
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-5626
>                 URL: https://issues.apache.org/jira/browse/OAK-5626
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Minor
>              Labels: candidate_oak_1_0
>             Fix For: 1.2.24, 1.4.14, 1.7.0, 1.8, 1.6.1
>
>         Attachments: OAK-5626.patch, OAK-5626-v2.patch, OAK-5626-v3.patch
>
>
> Following up on conversation at \[0]:
> {{ChangeProcessor#queueSizeChanged}} \[1] sets blocking flag to true if queue size is
hit (or beyond). The warning "Revision queue is full. Further revisions will be compacted."
is logged only when it *wasn't* blocking.
> BUT, when queue empties, blocking flag is reset inside if block for commitRateLimiter!=null.
That means an event chain like: 
> # qFull
> # log warn
> # qEmpties
> # qFull 
> won't log the WARN after step(4)
> \[0]: http://markmail.org/message/hgein5g3ohyjhw5n
> \[1]: https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/ChangeProcessor.java#L307



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message