jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected
Date Tue, 21 Feb 2017 12:29:44 GMT

    [ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875908#comment-15875908

Marcel Reutegger commented on OAK-5704:

I like the idea of resetting the deletedOnce flag. A couple of comments about the patch:

- The patch adds the current document id to the info message logged in collectDeletedDocuments().
I'm not sure how useful this is. The documents can be in arbitrary order and might give a
false sense of progress.
- In resetDeletedOnce(), I would rather log "Proceeding to reset ...".
- The UpdateOp sets the _deletedOnce flag to false. I would prefer a new remove() method on
UpdateOp. At least with MongoDB there is a sparse index on _deletedOnce and we are only interested
in documents that have this field set to true. Documents with a _deletedOnce set to false
would bloat the index. With MongoDB 3.2 we could work around this with a partial index, but
I think it would be cleaner to remove the field.
- The UpdateOp also updates the _modified field. This field is related to revisioned entries
on the document. I think it would be better to leave the value as is, because there is no
actual modification on the node related to this update.

> VersionGC: reset _deletedOnce for documents that have been resurrected
> ----------------------------------------------------------------------
>                 Key: OAK-5704
>                 URL: https://issues.apache.org/jira/browse/OAK-5704
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: OAK-5704.diff

This message was sent by Atlassian JIRA

View raw message