jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5704) VersionGC: reset _deletedOnce for documents that have been resurrected
Date Tue, 21 Feb 2017 12:49:44 GMT

    [ https://issues.apache.org/jira/browse/OAK-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875920#comment-15875920
] 

Julian Reschke commented on OAK-5704:
-------------------------------------

bq. The patch adds the current document id to the info message logged in collectDeletedDocuments().
I'm not sure how useful this is. The documents can be in arbitrary order and might give a
false sense of progress.

Ah. It was supposed to give a sense of progress; I assumed that the query indeed returns the
documents sorted by {{_id}} - it does in RDB, and also everywhere else in the document store
API.

bq. In resetDeletedOnce(), I would rather log "Proceeding to reset ...".

Ack.

bq. The UpdateOp sets the _deletedOnce flag to false. I would prefer a new remove() method
on UpdateOp. At least with MongoDB there is a sparse index on _deletedOnce and we are only
interested in documents that have this field set to true. Documents with a _deletedOnce set
to false would bloat the index. With MongoDB 3.2 we could work around this with a partial
index, but I think it would be cleaner to remove the field.

Ack.

bq. The UpdateOp also updates the _modified field. This field is related to revisioned entries
on the document. I think it would be better to leave the value as is, because there is no
actual modification on the node related to this update.

Yes, I wasn't sure about whether we should update _modified.


> VersionGC: reset _deletedOnce for documents that have been resurrected
> ----------------------------------------------------------------------
>
>                 Key: OAK-5704
>                 URL: https://issues.apache.org/jira/browse/OAK-5704
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>         Attachments: OAK-5704.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message