jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikas Saurabh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3070) Use a lower bound in VersionGC query to avoid checking unmodified once deleted docs
Date Thu, 09 Mar 2017 11:02:38 GMT

    [ https://issues.apache.org/jira/browse/OAK-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902879#comment-15902879
] 

Vikas Saurabh commented on OAK-3070:
------------------------------------

bq. Now, with the patch, this is basically pushed to the database.
I don't think that's completely accurate. Afaiu, the DB was doing the work anyway - document
logic was discarding those results. Now, with lower bound, we're avoiding those results to
be sent across the wire.

bq. For the scope of this issue, I would simply lift the query timeout. 
To me, until other improvements come in, this seems a reasonable option.

I think this issue doesn't require index as much right away - in the sense that the DB load
would still suck but we can still manage data over wire and discard-after-reading in gc logic.

> Use a lower bound in VersionGC query to avoid checking unmodified once deleted docs
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-3070
>                 URL: https://issues.apache.org/jira/browse/OAK-3070
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk, rdbmk
>            Reporter: Chetan Mehrotra
>            Assignee: Vikas Saurabh
>              Labels: performance
>         Attachments: OAK-3070-2.patch, OAK-3070-3.patch, OAK-3070.patch, OAK-3070-updated.patch,
OAK-3070-updated.patch
>
>
> As part of OAK-3062 [~mreutegg] suggested
> {quote}
> As a further optimization we could also limit the lower bound of the _modified
> range. The revision GC does not need to check documents with a _deletedOnce
> again if they were not modified after the last successful GC run. If they
> didn't change and were considered existing during the last run, then they
> must still exist in the current GC run. To make this work, we'd need to
> track the last successful revision GC run. 
> {quote}
> Lowest last validated _modified can be possibly saved in settings collection and reused
for next run



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message