jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-3878) Avoid caching of NodeDocument while iterating in BlobReferenceIterator
Date Wed, 08 Mar 2017 13:56:38 GMT

    [ https://issues.apache.org/jira/browse/OAK-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901286#comment-15901286
] 

Marcel Reutegger commented on OAK-3878:
---------------------------------------

I would rather not add more implementation specific classes. This increases complexity and
e.g. makes testing more difficult.

> Avoid caching of NodeDocument while iterating in BlobReferenceIterator
> ----------------------------------------------------------------------
>
>                 Key: OAK-3878
>                 URL: https://issues.apache.org/jira/browse/OAK-3878
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.8
>
>
> {{BlobReferenceIterator}} in DocumentMK makes use of {{DocumentStore}} API to query the
NodeDocument. This would cause all those NodeDocuments to be added to cache in DocumentStore.
Due to this when blob gc is running cache usage would not be that effective due to all the
associated churn. 
> As these NodeDocument are only required for BlobGC logic and its not expected that this
document would read again soon it would be better to skip caching of these documents within
DocumentStore
> Similar requirement exist in VersionGC logic but there we use direct store based API
which does not add such documents to the cache



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message