jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-4920) DefaultSyncHandler.listIdentities() search too broad, triggers traversal warning
Date Mon, 06 Mar 2017 11:21:32 GMT

    [ https://issues.apache.org/jira/browse/OAK-4920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897118#comment-15897118

angela commented on OAK-4920:

more investigation and with OAK-5743 in place the traversal warning is gone with the following
user query:

        final Iterator<Authorizable> iter = userManager.findAuthorizables(DefaultSyncContext.REP_EXTERNAL_ID,

note however, that with the {{ListIdentitiesTest}} benchmark used to search for all external
users (always roughly 100 non-external groups/users present), there doesn't seem to be a significant
performance impact. just the traversal warning is gone. 
See however OAK-5892 for an additional improvement that seems to have a bigger impact on the
user query performance.

> DefaultSyncHandler.listIdentities() search too broad, triggers traversal warning
> --------------------------------------------------------------------------------
>                 Key: OAK-4920
>                 URL: https://issues.apache.org/jira/browse/OAK-4920
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: auth-external
>    Affects Versions: 1.4.8, 1.5.11
>            Reporter: Alexander Klimetschek
>            Assignee: angela
>              Labels: performance
>             Fix For: 1.8
> DefaultSyncHandler.listIdentities() collects users by [searching for all nodes under
– the xpath query executed is
> {noformat}
> /jcr:root/home//element(*)[@jcr:primaryType]
> {noformat}
> With a few hundred users this easily gives an oak index traversal warning:
> {noformat}
> org.apache.jackrabbit.oak.spi.query.Cursors$TraversingCursor Traversed 1000 nodes with
filter Filter(query=select [jcr:path], [jcr:score], * from [nt:base] as a where [jcr:primaryType]
is not null and isdescendantnode(a, '/home') /* xpath: /jcr:root/home//element(*)[@jcr:primaryType]
*/, path=/home//*, property=[jcr:primaryType=[is not null]]); consider creating an index or
changing the query
> {noformat}
> A few lines later [it actually reduces|https://github.com/apache/jackrabbit-oak/blob/b3e62e3467bf6433b5a419c2f371331f33e57820/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/DefaultSyncHandler.java#L151]
the result to authorizables which have a {{rep:externalId}}. Since OAK-4301 there is an oak
index for {{rep:externalId}}, so the query can be optimized by searching for anything with
{{rep:externalId}} instead:
> {code:java}
> userManager.findAuthorizables("rep:externalId", null);
> {code}

This message was sent by Atlassian JIRA

View raw message