jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Mehrotra (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-5656) InitialContent depends on document.bundlor.BundlingConfigInitializer
Date Wed, 13 Sep 2017 13:02:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164608#comment-16164608
] 

Chetan Mehrotra commented on OAK-5656:
--------------------------------------

Lets go for inline approach for now as it appears we need to extend the patterns also for
custom nodetypes. If required we can export it later

> InitialContent depends on document.bundlor.BundlingConfigInitializer
> --------------------------------------------------------------------
>
>                 Key: OAK-5656
>                 URL: https://issues.apache.org/jira/browse/OAK-5656
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>            Assignee: Marcel Reutegger
>            Priority: Minor
>              Labels: modularization, tech-debt
>             Fix For: 1.8
>
>         Attachments: OAK-5656.patch, OAK-5656.patch
>
>
> [~chetanm], in the light of OAK-4975 a dependency to the document nodestore code got
introduced in {{org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent}} by adding
the following line:
> {code}
>         BundlingConfigInitializer.INSTANCE.initialize(builder);
> {code}
> the {{BundlingConfigInitializer}} is defined in the {{org.apache.jackrabbit.oak.plugins.document.bundlor}}.
> To me that looks quite troublesome and I don't think the generic JCR-InitialContent should
have any dependency on the document nodestore code base.
> Why not defining a dedicated {{RepositoryInitializer}} for that kind of init an making
sure it is listed in the (default) setup scenarios (or at least in those that actually have
a document store and thus require this)?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message