jackrabbit-oak-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OAK-6318) Refactor oak.spi.security into a separate module/bundle
Date Tue, 26 Sep 2017 09:46:00 GMT

    [ https://issues.apache.org/jira/browse/OAK-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180551#comment-16180551
] 

Alex Deparvu commented on OAK-6318:
-----------------------------------

[~anchela] I tried to approach the tree refactoring a bit differently, but ended up pretty
close to what you had originally, with some minor diffs
* kept {{TreeConstants}} but moved it to {{org.apache.jackrabbit.oak.plugins.tree.TreeConstants}}
* introduced a new interface {{TreeTypeAware}} to replace usage of {{ImmutableTree}} and reduce
changes to {{AbstractTree}}
* no way around the factories changes, which means in the end major version increase of the
package export

see this branch [0], where I did a best effort merge of trunk post release, oak pojosr tests
are failing and I'm not sure why.
outside of the tree stuff there's still the {{IndexConstants}} change, I can take care of
that next.

[0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:oak-6318-rebase

> Refactor oak.spi.security into a separate module/bundle
> -------------------------------------------------------
>
>                 Key: OAK-6318
>                 URL: https://issues.apache.org/jira/browse/OAK-6318
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, security
>            Reporter: angela
>         Attachments: PropInfo.patch
>
>
> In the light of the modularization effort it would IMHO make a lot of sense to refactor
_oak.spi.security.*_ into a separate module/bundle that could be release independent of _oak-core_.
> As far as I could see so far this is currently not easily doable due to the dependency
of {{oak.spi.security.*}} on {{oak.plugins.tree}}, which in turn relies on {{o.a.j.oak.query.QueryEngineSettings}}
and other oak-core internals (see also OAK-6304). Most likely this issue would therefore require
a complete review (and possibly a split) of  the {{oak.plugins.tree}} package space which
contains a mixture of utilities and 'API' (like e.g. {{TreeContext}} and {{TreeLocation}})...
will open a separate issue for this linking to this one.
> cc: [~stillalex], [~rombert], [~mduerig], [~tmueller]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message